Skip to content

Checksum :client instead :client_id#28

Closed
heygambo wants to merge 2 commits intopaymill:masterfrom
heygambo:master
Closed

Checksum :client instead :client_id#28
heygambo wants to merge 2 commits intopaymill:masterfrom
heygambo:master

Conversation

@heygambo
Copy link
Copy Markdown

Hi, I've tried to create a new paypal transaction and bind it to a client.

It seems like the the attribute is called client instead of client_id
Reference: https://developers.paymill.com/guides/paypal/transactions.html#optional-transaction-details

With this code change paypal associates the payment to the given client instead of creating a new one every time.

Changed :client_id to :client
Changed :client_id to :client
@nikoloff
Copy link
Copy Markdown

nikoloff commented Dec 1, 2015

Hi @NerdyGlasses
Currently the API works with both attributes (client and client_id). I will leave this PR open until we got a decision in the API which name will be used.

@cyrrill
Copy link
Copy Markdown

cyrrill commented Dec 27, 2015

API calls, at least as tested from the PHP client did not work with client_id. Once it was changed to client, everything worked fine.

Please see: paymill/paymill-php#114 (comment)

@heygambo
Copy link
Copy Markdown
Author

okay cool thx for looking into it. Hope you had nice holidays.

@heygambo heygambo closed this Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants